Do not add "undefined" to the beginning of the result of .fixMarkup() #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to keep to the existing code style, and I added a test for the fix. |
isagalaev
requested changes
Feb 18, 2017
src/highlight.js
Outdated
| @@ -593,6 +593,7 @@ https://highlightjs.org/ | |||
| } else if (options.tabReplace) { | |||
| return p1.replace(/\t/g, options.tabReplace); | |||
| } | |||
| return ""; | |||
There was a problem hiding this comment.
A tiny nit: could you use single quotes for strings as in the rest of the code? :-)
Fixes highlightjs#1452 - Added default return value (empty string) to the ".replace()" call.
|
Oops... That's the thing with german keyboards. Typing I've changed that and made a force-push to my branch to no pollute history... |
isagalaev
approved these changes
Feb 18, 2017
|
Thanks, merged! (Don't really care about history "pollution" myself :-) ) |
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1452